-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switched back to
DeferWindowPos (#127)
## Removed - `Win32Helper.SetWindowPos` ## Changed - Replaced usage of `Win32Helper.SetWindowPos` with `WindowDeferPosHandle` or `WindowDeferPosHandle.SetWindowPos` - Fixed debug values in `Win32Helper`
- Loading branch information
Showing
10 changed files
with
172 additions
and
87 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using Windows.Win32; | ||
| using Windows.Win32.Foundation; | ||
| using Windows.Win32.UI.WindowsAndMessaging; | ||
|
|
||
| namespace Whim; | ||
|
|
||
| /// <summary> | ||
| /// Sets the position of multiple windows at once, using <see cref="PInvoke.DeferWindowPos"/>. | ||
| /// As stated in Raymond Chen's blog post (https://devblogs.microsoft.com/oldnewthing/20050706-26/?p=35023), | ||
| /// this reduces the amount of repainting. | ||
| /// </summary> | ||
| public sealed class WindowDeferPosHandle : IDisposable | ||
| { | ||
| private nint _hWinPosInfo; | ||
| private readonly List<IWindow> _toMinimize; | ||
| private readonly List<IWindow> _toMaximize; | ||
| private readonly List<IWindow> _toNormal; | ||
|
|
||
| /// <summary> | ||
| /// Create a new <see cref="WindowDeferPosHandle"/> for <paramref name="count"/> windows. | ||
| /// This is to be used when setting the position of multiple windows at once. | ||
| /// | ||
| /// <see cref="WindowDeferPosHandle"/> must be used in conjunction with a <c>using</c> block | ||
| /// or statement, otherwise <see cref="PInvoke.EndDeferWindowPos"/> won't be called. | ||
| /// </summary> | ||
| /// <param name="count">The number of windows to layout.</param> | ||
| public WindowDeferPosHandle(int count) | ||
| { | ||
| _hWinPosInfo = PInvoke.BeginDeferWindowPos(count); | ||
|
|
||
| _toMinimize = new List<IWindow>(); | ||
| _toMaximize = new List<IWindow>(); | ||
| _toNormal = new List<IWindow>(); | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public void Dispose() | ||
| { | ||
| foreach (IWindow w in _toMinimize) | ||
| { | ||
| if (!w.IsMinimized) | ||
| { | ||
| Win32Helper.MinimizeWindow(w.Handle); | ||
| } | ||
| } | ||
|
|
||
| foreach (IWindow w in _toMaximize) | ||
| { | ||
| if (!w.IsMaximized) | ||
| { | ||
| Win32Helper.ShowWindowMaximized(w.Handle); | ||
| } | ||
| } | ||
|
|
||
| foreach (IWindow w in _toNormal) | ||
| { | ||
| Win32Helper.ShowWindowNoActivate(w.Handle); | ||
| } | ||
|
|
||
| PInvoke.EndDeferWindowPos(_hWinPosInfo); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Using the given <paramref name="windowState"/>, sets the window's position. | ||
| /// </summary> | ||
| /// <param name="windowState"></param> | ||
| /// <param name="hwndInsertAfter">The window handle to insert show the given window behind.</param> | ||
| public void DeferWindowPos(IWindowState windowState, HWND? hwndInsertAfter = null) | ||
| { | ||
| // We use HWND_BOTTOM, as modifying the Z-order of a window | ||
| // may cause EVENT_SYSTEM_FOREGROUND to be set, which in turn | ||
| // causes the relevant window to be focused, when the user hasn't | ||
| // actually changed the focus. | ||
| hwndInsertAfter ??= (HWND)1; // HWND_BOTTOM | ||
|
|
||
| IWindow window = windowState.Window; | ||
|
|
||
| ILocation<int> offset = Win32Helper.GetWindowOffset(window.Handle); | ||
| ILocation<int> location = Location.Add(windowState.Location, offset); | ||
|
|
||
| WindowSize windowSize = windowState.WindowSize; | ||
|
|
||
| SET_WINDOW_POS_FLAGS flags = SET_WINDOW_POS_FLAGS.SWP_FRAMECHANGED | ||
| | SET_WINDOW_POS_FLAGS.SWP_NOACTIVATE | ||
| | SET_WINDOW_POS_FLAGS.SWP_NOCOPYBITS | ||
| | SET_WINDOW_POS_FLAGS.SWP_NOZORDER | ||
| | SET_WINDOW_POS_FLAGS.SWP_NOOWNERZORDER; | ||
|
|
||
| if (windowSize == WindowSize.Maximized) | ||
| { | ||
| _toMaximize.Add(window); | ||
| flags = flags | SET_WINDOW_POS_FLAGS.SWP_NOMOVE | SET_WINDOW_POS_FLAGS.SWP_NOSIZE; | ||
| } | ||
| else if (windowSize == WindowSize.Minimized) | ||
| { | ||
| _toMinimize.Add(window); | ||
| flags = flags | SET_WINDOW_POS_FLAGS.SWP_NOMOVE | SET_WINDOW_POS_FLAGS.SWP_NOSIZE; | ||
| } | ||
| else | ||
| { | ||
| _toNormal.Add(window); | ||
| } | ||
|
|
||
| _hWinPosInfo = PInvoke.DeferWindowPos( | ||
| _hWinPosInfo, | ||
| window.Handle, | ||
| (HWND)hwndInsertAfter, | ||
| location.X, | ||
| location.Y, | ||
| location.Width, | ||
| location.Height, | ||
| flags); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Set the position of a single window. | ||
| /// </summary> | ||
| /// <param name="windowState"></param> | ||
| /// <param name="hwndInsertAfter">The window handle to insert show the given window behind.</param> | ||
| public static void SetWindowPos(IWindowState windowState, HWND? hwndInsertAfter = null) | ||
| { | ||
| using WindowDeferPosHandle handle = new(1); | ||
| handle.DeferWindowPos(windowState, hwndInsertAfter); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.