Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Komorebi app rules rename #1040

Closed
dalyIsaac opened this issue Oct 1, 2024 · 1 comment · Fixed by #1041
Closed

Handle Komorebi app rules rename #1040

dalyIsaac opened this issue Oct 1, 2024 · 1 comment · Fixed by #1041
Assignees
Labels
auto app rules Pull requests that update the app rules engineering Build/architecture/upgrading dependency features

Comments

@dalyIsaac
Copy link
Owner

LGUG2Z/komorebi@b32bef7 heads up that float_identifiers will probably be renamed to ignore_identifiers as part of some ongoing work to make a distinction between completely ignored hwnds and managed-but-floating hwnds

Komorebi added a backwards-compat alias to ensure that float_identifiers can still be used upstream for a version or two, not sure if this is something you can also do to ensure forward-compat for ignore_identifiers

@dalyIsaac dalyIsaac added this to Whim Oct 1, 2024
@dalyIsaac dalyIsaac converted this from a draft issue Oct 1, 2024
@dalyIsaac dalyIsaac added auto app rules Pull requests that update the app rules engineering Build/architecture/upgrading dependency features labels Oct 1, 2024
@urob
Copy link
Contributor

urob commented Oct 1, 2024

Feel free to assign me on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto app rules Pull requests that update the app rules engineering Build/architecture/upgrading dependency features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants