Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Komorebi app rules rename #1041

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

urob
Copy link
Contributor

@urob urob commented Oct 2, 2024

  • This code is up-to-date with the main branch.
  • I have updated relevant (if any) areas in the docs.

This PR fixes #1040

Both ignore_identifiers and float_identifiers rules add a filter rule on the Whim side. Duplicates are taken care of using the default de-deduplication handling in the script.

Some things to look out for in the future:

  • For now there are no rules in https://github.com/LGUG2Z/komorebi-application-specific-configuration with the new identifier, so we could wait merging this PR. On the other hand, merging now should be harmless as it is backward compatible. In either case, I'll be monitoring the Komorebi-rules repo to make sure that all ignore-rules use one of the two identifiers

  • It is not entirely clear to me at this point whether, float_rules will be eventually repurposed to mean "managed but starting as floating". If another change to this effect will be rolled we need to decide how to handle that on the Whim side

@dalyIsaac dalyIsaac added auto app rules Pull requests that update the app rules engineering Build/architecture/upgrading dependency features labels Oct 2, 2024
@dalyIsaac
Copy link
Owner

It is not entirely clear to me at this point whether, float_rules will be eventually repurposed to mean "managed but starting as floating". If another change to this effect will be rolled we need to decide how to handle that on the Whim side

I think we could do something similar to our existing generation and create config for the floating plugin.

@dalyIsaac dalyIsaac merged commit 01188d7 into dalyIsaac:main Oct 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto app rules Pull requests that update the app rules engineering Build/architecture/upgrading dependency features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Komorebi app rules rename
2 participants