Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
branch.This PR fixes #1040
Both
ignore_identifiers
andfloat_identifiers
rules add afilter
rule on the Whim side. Duplicates are taken care of using the default de-deduplication handling in the script.Some things to look out for in the future:
For now there are no rules in https://github.com/LGUG2Z/komorebi-application-specific-configuration with the new identifier, so we could wait merging this PR. On the other hand, merging now should be harmless as it is backward compatible. In either case, I'll be monitoring the Komorebi-rules repo to make sure that all ignore-rules use one of the two identifiers
It is not entirely clear to me at this point whether,
float_rules
will be eventually repurposed to mean "managed but starting as floating". If another change to this effect will be rolled we need to decide how to handle that on the Whim side