Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of events for the core #103

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

dalyIsaac
Copy link
Owner

No description provided.

@dalyIsaac dalyIsaac added refactor The code can be simplified/moved/cleaned up core Whim labels Jul 3, 2022
@dalyIsaac dalyIsaac linked an issue Jul 3, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #103 (de66feb) into main (768798d) will decrease coverage by 0.85%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   38.49%   37.64%   -0.86%     
==========================================
  Files          74       74              
  Lines        3686     3690       +4     
  Branches      456      460       +4     
==========================================
- Hits         1419     1389      -30     
- Misses       2194     2232      +38     
+ Partials       73       69       -4     
Impacted Files Coverage Δ
src/Whim/Monitor/MonitorManager.cs 0.00% <0.00%> (ø)
src/Whim/Window/WindowManager.cs 0.00% <0.00%> (ø)
src/Whim/Workspace/Workspace.cs 0.00% <0.00%> (ø)
src/Whim/Workspace/WorkspaceManager.cs 45.60% <0.00%> (-6.94%) ⬇️
src/Whim/Workspace/RouteEvent.cs 0.00% <0.00%> (-83.34%) ⬇️
src/Whim/Window/WindowEvents.cs 0.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768798d...de66feb. Read the comment docs.

@dalyIsaac dalyIsaac merged commit d092d52 into main Jul 3, 2022
@dalyIsaac dalyIsaac deleted the 99-remove-usage-of-events-for-the-core branch July 3, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim refactor The code can be simplified/moved/cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of events for the core
2 participants