Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SliceLayouts.CreateColumnLayout creating a row layout #1039

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Sep 27, 2024

The tests previously succeeded because:

  • the SliceLayoutEngine record didn't expose the root area, which meant they were not included in the generated record Equals
  • apparently casting ILayoutEngine to SliceLayoutEngine matters 🤷

@dalyIsaac dalyIsaac added bug Something isn't working slice layout Whim.SliceLayout labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (6b195f7) to head (2b948be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   80.47%   80.55%   +0.07%     
==========================================
  Files         280      280              
  Lines       11986    11988       +2     
  Branches     1373     1373              
==========================================
+ Hits         9646     9657      +11     
+ Misses       2166     2157       -9     
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac force-pushed the slicelayoutengine-fixes branch from 7c9320d to 02eec8f Compare September 28, 2024 11:21
@dalyIsaac dalyIsaac marked this pull request as ready for review October 1, 2024 12:49
@dalyIsaac dalyIsaac merged commit 0c9707a into main Oct 1, 2024
8 checks passed
@dalyIsaac dalyIsaac deleted the slicelayoutengine-fixes branch October 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working slice layout Whim.SliceLayout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant