Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide YAML config by default #1067

Merged
merged 7 commits into from
Nov 3, 2024
Merged

Conversation

dalyIsaac
Copy link
Owner

Whim now creates a YAML config if one doesn't exist during startup. The docs have been updated to reflect that YAML is now the default option.

Existing configs are not overwritten.

@dalyIsaac dalyIsaac added enhancement New feature or request yaml/json config The alternative to using C# scripts labels Nov 3, 2024
@dalyIsaac dalyIsaac linked an issue Nov 3, 2024 that may be closed by this pull request
17 tasks
@dalyIsaac dalyIsaac force-pushed the 1063-provide-yaml-config-by-default branch from 582b612 to 429a77a Compare November 3, 2024 04:30
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (fe8e309) to head (ff6425e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Whim/ConfigLoader/ConfigLoader.cs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   80.57%   80.58%           
=======================================
  Files         283      283           
  Lines       12419    12418    -1     
  Branches     1434     1434           
=======================================
  Hits        10007    10007           
+ Misses       2227     2226    -1     
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac force-pushed the 1063-provide-yaml-config-by-default branch from 429a77a to ff6425e Compare November 3, 2024 05:58
@dalyIsaac dalyIsaac marked this pull request as ready for review November 3, 2024 06:12
@dalyIsaac dalyIsaac merged commit 8206b19 into main Nov 3, 2024
7 of 8 checks passed
@dalyIsaac dalyIsaac deleted the 1063-provide-yaml-config-by-default branch November 3, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request yaml/json config The alternative to using C# scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide YAML config by default
1 participant