Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crashes when creating new workspaces with a YAML config #1068

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

dalyIsaac
Copy link
Owner

This PR fixes a critical crash which would occur when creating a workspace during runtime (after startup).

The issue was that a TreeLayoutPlugin event was not enqueued onto the WinUI dispatcher.

@dalyIsaac dalyIsaac added bug Something isn't working tree layout Whim.TreeLayout labels Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (bd17c2c) to head (3138c6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         283      283           
  Lines       12409    12412    +3     
  Branches     1432     1432           
=======================================
+ Hits         9997    10000    +3     
  Misses       2227     2227           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review November 3, 2024 04:26
@dalyIsaac dalyIsaac merged commit 86eace7 into main Nov 3, 2024
11 checks passed
@dalyIsaac dalyIsaac deleted the fix-treelayoutplugin-crash branch November 3, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tree layout Whim.TreeLayout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant