Prevent gaps-triggered shifting for FloatingLayoutEngine
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalyIsaac
force-pushed
the
prevent-floatinglayoutengine-shift
branch
from
4324189 to
5fe81d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
+ Coverage 80.56% 80.57% +0.01%
==========================================
Files 283 283
Lines 12412 12419 +7
Branches 1432 1434 +2
==========================================
+ Hits 10000 10007 +7
Misses 2227 2227
Partials 185 185 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was special handling for the
ProxyFloatingLayoutEngine, butFloatingLayoutEnginewas not included. As a result, windows could shift while using theFloatingLayoutEngine. This PR fixes this.