Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkspaceWidget to support sticky workspaces #1072

Merged
merged 6 commits into from
Nov 10, 2024
Merged

Conversation

dalyIsaac
Copy link
Owner

The WorkspaceWidget now shows the workspaces which can be opened on the monitor the Bar is open on.

The legacy API was removed from WorkspaceWidgetViewModel as part of this work.

@dalyIsaac dalyIsaac added enhancement New feature or request bar Whim.Bar labels Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 97.70115% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.52%. Comparing base (1fe72a1) to head (40cb4f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Whim/Store/MapSector/MapPickers.cs 96.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   80.52%   80.52%   -0.01%     
==========================================
  Files         283      283              
  Lines       12655    12715      +60     
  Branches     1458     1464       +6     
==========================================
+ Hits        10191    10239      +48     
- Misses       2274     2286      +12     
  Partials      190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review November 10, 2024 06:19
@dalyIsaac dalyIsaac merged commit 51eba21 into main Nov 10, 2024
8 checks passed
@dalyIsaac dalyIsaac deleted the sticky-monitor-bar branch November 10, 2024 06:28
@dalyIsaac dalyIsaac linked an issue Nov 11, 2024 that may be closed by this pull request
31 tasks
@dalyIsaac dalyIsaac mentioned this pull request Nov 11, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bar Whim.Bar enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky monitor workspaces
1 participant