Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Corvus.JsonSchema 4 #1081

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Upgrade to Corvus.JsonSchema 4 #1081

merged 5 commits into from
Nov 19, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Nov 17, 2024

  • Upgraded dependencies to their latest version
  • Upgraded to Corvus.Json 4
  • Switched to using a source generator for the schema parser/validator

@dalyIsaac dalyIsaac requested a review from Copilot November 17, 2024 05:19
@dalyIsaac dalyIsaac added dependencies Pull requests that update a dependency file yaml/json config The alternative to using C# scripts refactor The code can be simplified/moved/cleaned up labels Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated no suggestions.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.74%. Comparing base (275b519) to head (32cc08b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Whim.Yaml/YamlBarPluginLoader.cs 92.59% 0 Missing and 2 partials ⚠️
src/Whim.Yaml/YamlPluginLoader.cs 97.14% 0 Missing and 2 partials ⚠️
src/Whim.Yaml/YamlLoaderUtils.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
+ Coverage   80.66%   80.74%   +0.08%     
==========================================
  Files         284      284              
  Lines       12865    12898      +33     
  Branches     1483     1491       +8     
==========================================
+ Hits        10378    10415      +37     
+ Misses       2292     2290       -2     
+ Partials      195      193       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dalyIsaac dalyIsaac marked this pull request as ready for review November 19, 2024 08:04
@dalyIsaac dalyIsaac merged commit 580e1d0 into main Nov 19, 2024
10 checks passed
@dalyIsaac dalyIsaac deleted the update-deps branch November 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor The code can be simplified/moved/cleaned up yaml/json config The alternative to using C# scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant