Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit support #155

Merged
merged 21 commits into from
Jul 22, 2022
Merged

Exit support #155

merged 21 commits into from
Jul 22, 2022

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Jul 21, 2022

  • IConfigContext and ConfigContext can now be shut down.
  • Added the events IConfigContext.Exit and IConfigContext.Exiting.
  • Added a command to Exit from the IConfigContext.
  • Renamed all disposedValue variables to _disposedValue.
  • Updated the following to be IDisposable:
    • CommandPalettePlugin
    • FocusIndicatorPlugin
    • IWorkspace
    • IWorkspaceManager
    • Logger
    • SwitchWorkspaceCommand
    • TreeLayoutEngineWidget
    • WorkspaceWidget
  • Unsubscribed to IConfigContext and IWindow events in Dispose methods.
  • Whim.Runner.App now starts the Whim engine, instead of taking it as an argument from Program.Main.
  • Whim.Runner.App now responds to the IConfigContext having completed exiting.
  • Moved the loading and provisioning of the config from Whim.Runner to Whim.ConfigContext.Initialize.
  • DoConfig no longer returns IConfigContext.

@dalyIsaac dalyIsaac added enhancement New feature or request core Whim labels Jul 21, 2022
@dalyIsaac dalyIsaac linked an issue Jul 21, 2022 that may be closed by this pull request
3 tasks
@dalyIsaac dalyIsaac changed the title Quit support Exit support Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #155 (63d28b6) into main (9ba2dd2) will decrease coverage by 0.95%.
The diff coverage is 10.05%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   41.00%   40.05%   -0.96%     
==========================================
  Files          76       78       +2     
  Lines        3748     3882     +134     
  Branches      471      483      +12     
==========================================
+ Hits         1537     1555      +18     
- Misses       2131     2247     +116     
  Partials       80       80              
Impacted Files Coverage Δ
src/Whim.CommandPalette/CommandPalettePlugin.cs 0.00% <0.00%> (ø)
src/Whim/Commands/CommandManager.cs 0.00% <0.00%> (ø)
src/Whim/Commands/DefaultCommands.cs 0.00% <0.00%> (ø)
src/Whim/Commands/KeybindManager.cs 0.00% <0.00%> (ø)
src/Whim/ConfigContext/ConfigContext.cs 0.00% <0.00%> (ø)
src/Whim/ConfigContext/ExitEventArgs.cs 0.00% <0.00%> (ø)
src/Whim/ConfigLoader/ConfigLoader.cs 0.00% <0.00%> (ø)
src/Whim/ConfigLoader/ConfigLoaderException.cs 0.00% <0.00%> (ø)
src/Whim/Engine.cs 0.00% <0.00%> (ø)
src/Whim/Logging/Logger.cs 9.09% <0.00%> (-3.16%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba2dd2...63d28b6. Read the comment docs.

@dalyIsaac dalyIsaac marked this pull request as ready for review July 22, 2022 02:36
@dalyIsaac dalyIsaac merged commit 6d7c39f into main Jul 22, 2022
@dalyIsaac dalyIsaac deleted the 150-suspendresumequit-support branch July 22, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quit command
2 participants