Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from saying register/unregister to add/remove #160

Conversation

dalyIsaac
Copy link
Owner

No description provided.

@dalyIsaac dalyIsaac added the refactor The code can be simplified/moved/cleaned up label Jul 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #160 (e57fbf9) into main (8b3bf3a) will not change coverage.
The diff coverage is 7.89%.

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   39.95%   39.95%           
=======================================
  Files          78       78           
  Lines        3892     3892           
  Branches      485      485           
=======================================
  Hits         1555     1555           
  Misses       2257     2257           
  Partials       80       80           
Impacted Files Coverage Δ
src/Whim/Plugin/PluginManager.cs 0.00% <ø> (ø)
src/Whim/Window/IWindow.cs 0.00% <0.00%> (ø)
src/Whim/Workspace/IWorkspace.cs 0.00% <ø> (ø)
src/Whim/Workspace/RouteEvent.cs 0.00% <ø> (ø)
src/Whim/Workspace/Workspace.cs 0.00% <0.00%> (ø)
src/Whim/Workspace/WorkspaceManager.cs 47.03% <0.00%> (ø)
src/Whim/Window/WindowManager.cs 6.66% <4.00%> (ø)
src/Whim.TreeLayout/TreeLayoutEngine.cs 72.95% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3bf3a...e57fbf9. Read the comment docs.

@dalyIsaac dalyIsaac merged commit e5bd01b into main Jul 25, 2022
@dalyIsaac dalyIsaac deleted the 149-make-phantom-window-methods-in-iworkspace-consistent-with-addwindow-and-removewindow branch July 25, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The code can be simplified/moved/cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make phantom window methods in IWorkspace consistent with AddWindow and RemoveWindow
2 participants