-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin architecture #209
Conversation
Codecov ReportBase: 42.66% // Head: 46.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 42.66% 46.34% +3.68%
==========================================
Files 89 98 +9
Lines 4360 4646 +286
Branches 559 577 +18
==========================================
+ Hits 1860 2153 +293
+ Misses 2402 2392 -10
- Partials 98 101 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Core
ICommandItemContainer.Add(string commandIdentifier, ...)
toICommandItemContainer.SetKeybind(string commandIdentifier, ...)
. This better reflects the method's purpose.Plugins
PluginManager
.IPlugin.GetCommands
is nowIPlugin.Commands
.IPlugin.Commands
also have a classPluginNameCommands
, where each command is individually accessible. This makes them easier to test.PluginNameCommands
classes.