Last active layout

[urob]

• refactor Workspace to use SetLayoutEngine for setting the active layout engine
• keep track of prevLayoutEngineIndex
• new method to activate previously active layout
• rename UpdateLayoutEngine to CycleLayoutEngine -- this made more sense to me, but happy to revert if this isn't consensus
• rename TrySetLayoutEngine to SetLayoutEngineFromName -- this made more sense to me, but happy to revert if this isn't consensus

[urob]

Motivation:

    context.CommandManager.Add(
            identifier: "toggle_focus_layout",
            title: "Toggle focus layout",
            callback: () =>
            {
                if (context.WorkspaceManager.ActiveWorkspace.ActiveLayoutEngine.Name == "Focus")
                {
                    context.WorkspaceManager.ActiveWorkspace.LastActiveLayoutEngine();
                }
                else
                {
                    context.WorkspaceManager.ActiveWorkspace.SetLayoutEngineFromName("Focus");
                }
            }
    );

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (87b0a82) 81.21% compared to head (69b43f2) 81.12%.

Files	Patch %	Lines
src/Whim/Workspace/Workspace.cs	60.00%	8 Missing and 2 partials ⚠️
...c/Whim.Bar/ActiveLayout/NextLayoutEngineCommand.cs	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   81.21%   81.12%   -0.10%     
==========================================
  Files         191      191              
  Lines       10009    10011       +2     
  Branches     1123     1126       +3     
==========================================
- Hits         8129     8121       -8     
- Misses       1757     1765       +8     
- Partials      123      125       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[urob]

I wasn't fully sure when we need to lock access to the properties. When you do your final review, can you double check for all the refactored methods whether we have all locks needed and/or can omit some of them?

[urob]

I addressed most of the comments. Open issues:

• Should we omit [Previous|Next]LayoutEngine? See Last active layout #759 (comment)
• Naming of LastActiveLayoutEngine and (if not omitted) of [Previous|Next]LayoutEngine. See same comment for suggestions
• Double check whether locks are as needed

[urob]

Rebased on current main. Only the one question left about depreciating the remaining occurrence of NextLayoutEngine in WorkspacaeManagerTests.cs