Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always expose the workspace id when adding a workspace #977

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Aug 16, 2024

Previously, context.WorkspaceManager.Add() would return null in the csx. This was because it would only return IWorkspace once Whim had completed initialization.

Now, context.WorkspaceManager.Add() will return the Guid of the workspace that was added. This allows you to utilize the workspace id when setting up commands or other functionality that requires the workspace id.

@dalyIsaac dalyIsaac added enhancement New feature or request core Whim labels Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (f497291) to head (c6ab72a).
Report is 1 commits behind head on main.

Files Patch % Lines
...nitorSector/Transforms/MonitorsChangedTransform.cs 50.00% 0 Missing and 1 partial ⚠️
src/Whim/Workspace/WorkspaceManager.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files         274      274           
  Lines       11295    11303    +8     
  Branches     1277     1279    +2     
=======================================
+ Hits         9154     9161    +7     
  Misses       1970     1970           
- Partials      171      172    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac marked this pull request as ready for review August 16, 2024 13:23
@dalyIsaac dalyIsaac merged commit 895c46d into main Aug 16, 2024
6 checks passed
@dalyIsaac dalyIsaac deleted the add-workspace-get-id branch August 16, 2024 13:30
@urob
Copy link
Contributor

urob commented Aug 16, 2024

That's great! It'll allow me to get rid of some ugly hacks in my csx to refer to workspaces I create

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants