Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Options Behavior in FileReaderBuilder for Option Merging #17

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Modified Options Behavior in FileReaderBuilder for Option Merging #17

merged 1 commit into from
Nov 3, 2023

Conversation

paulsasi
Copy link
Contributor

@paulsasi paulsasi commented Nov 3, 2023

Issue --> #16

piffall
piffall approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@piffall piffall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piffall piffall merged commit 9fcb524 into damavis:develop Nov 3, 2023
1 check passed
@paulsasi paulsasi deleted the feature_16 branch November 11, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piffall piffall piffall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulsasi @piffall