Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for Dialog to close before exiting #5

Closed
wants to merge 1 commit into from

Conversation

pyther
Copy link

@pyther pyther commented Sep 2, 2022

When running the Setup your Mac.bash script from a Jamf policy, the dialog window will automatically close once Jamf is done executing the policy. This does not give the user a chance to review the status and read the final message update.

wait will wait block until all background jobs have completed.

@dan-snelson
Copy link
Owner

Thanks for the PR, @pyther.

This change would actually impact our workflow as we've trained our users (and TSRs) to expect an automatic reboot after starting the Jamf Pro policy. (We're using Restart Confirm, so the users have 60 seconds to review before reboot.)

What your opinion of using sleep NN instead (and I'll just enter a low value)?

@pyther
Copy link
Author

pyther commented Sep 8, 2022

Sleep is tricky because the user can close the dialog before the sleep completes and then you have a period of time when nothing happens. If you set sleep to a low value it may not matter that much but at higher values such as 60 or 120 seconds, it would become a lot more noticeable.

What would you think of adding an argument that would control if the script waited our exited immediately?

@dan-snelson
Copy link
Owner

Good point.

We've got Parameters 6 through 11 still available; do you want to modify your PR or shall I give it a go? (Not quite sure when that would be.)

@dan-snelson
Copy link
Owner

dan-snelson commented Sep 11, 2022

@pyther:

Please take a look at 1.2.7 (in the development branch) for a test-drive and let me know if it will meet your needs.

@dan-snelson
Copy link
Owner

Addressed by 1.2.7.

@pyther
Copy link
Author

pyther commented Sep 15, 2022

Sorry for the delay, I've been crazy busy. This looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants