Testing rework. Coverage! #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of helpful suggestion from a member of the Jest team, which indicated that it is possible to get Jest to find files to test (both source under test and unit test files) in
node_modulesdirectories. (It wasn't obvious that this was possible, and it took me a half day of looking at the Jest code before I filed the bug which elicited the very helpful suggestion.)After getting the new configuration done, I was very pleasantly surprised that test coverage reporting Just Worked™. And also happy to note that, it turns out, the project has ~50% coverage of lines-of-code and ~75% coverage of functions. That's not actually too shabby, given that I only bother writing unit tests when it seems that doing so will be a significant net development-time benefit.