Fix: [git] JSONDiffForFile when passed the path of a JSON File that was moved, crashes #1197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't crash when danger.git.JSONDiffForFile encounters a moved JSON file
Notably affects danger-plugin-yarn; when a package.json is moved, it slips by a test in
JSONPatchForFile
that filters fordanger.git.modified_files
, and I couldn't figure out how to fixgetFileContents
so it could look up the old file's contents using the new file path.Note: I also couldn't figure out how to generate the right fixtures, or how to mock
JSONPatchForFile
Fixes: #1181
Related: #481
Some useful test data