Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary support for .java, .html, .properties files #10

Merged
merged 8 commits into from
Oct 21, 2024

Conversation

Explicit on* attribute names based on HTML5 spec
Make patterns case-insensitive
Simplify event handler in Java file pattern
Remove lookbehinds to improve performance
Adapt test cases to slightly changed behavior
@basil
Copy link
Contributor

basil commented Oct 18, 2024

This is working pretty well for me, but I'm getting some errors in plugins with .properties and/or .html files that aren't UTF-8 encoded, such as credentials and subversion. As of jenkinsci/jenkins-test-harness#433 we can guarantee that .properties files are either UTF-8 or ISO-8859-1. I think it would be best to try UTF-8 first and fall back to ISO-8859-1, and then error if neither work out. I can help contribute the code for this if desired.

@daniel-beck
Copy link
Owner Author

As of jenkinsci/jenkins-test-harness#433 we can guarantee

Nice, that should be easy to do.

Copy link
Contributor

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me at the latest revision.

@daniel-beck daniel-beck merged commit 7c446de into main Oct 21, 2024
@daniel-beck daniel-beck deleted the other-file-types branch October 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for more file types
2 participants