Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #349 #1

Merged

Conversation

lkstrp
Copy link

@lkstrp lkstrp commented Oct 1, 2024

@daniel-rdt
As discussed:

  • Mainly removes the ambiguous solver attributes and clearly distinguish between direct io and via problem file
  • Use abstract base class

Still don't like the composition too much. The solver class could be improved a lot instead of just taking the same run function for each solver, but this needs much more refactoring

@daniel-rdt daniel-rdt merged commit d5ba71c into daniel-rdt:linopy_solver_class Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants