-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for qThreadExtraInfo #106
Add support for qThreadExtraInfo #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, this is looking good!
e31f252
to
ebaa9de
Compare
I think I've addressed all the feedback - let me know if there's any additional items you'd like to see addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let mut body = body.splitn_mut_no_panic(3, |b| *b == b','); | ||
let id = SpecificThreadId::try_from(ThreadId::try_from(body.next()?).ok()?).ok()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let mut body = body.splitn_mut_no_panic(3, |b| *b == b','); | |
let id = SpecificThreadId::try_from(ThreadId::try_from(body.next()?).ok()?).ok()?; | |
let id = SpecificThreadId::try_from(ThreadId::try_from(body).ok()?).ok()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
0dd8086
to
c6d81b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It's a bit late for me here, so I'll give it one last once-over in the morning just in case, but it should be good to go after resolving this last thing.
Add a new sub-IDET for `MultiThreadBase` to respond with extra information about a thread Signed-off-by: Ryan Fairfax <[email protected]>
c6d81b1
to
2e148ea
Compare
Thanks again for the contribution! Once #103 lands, I'll push out |
@thefaxman 0.6.2 has been released :) |
Description
Add a new sub-IDET for
MultiThreadBase
to respond with extra information about a thread.Closes #104
API Stability
Checklist
cargo build
compiles withouterrors
orwarnings
cargo clippy
runs withouterrors
orwarnings
cargo fmt
was runexamples/armv4t
examples/armv4t
withRUST_LOG=trace
+ any relevant GDB output under the "Validation" section below./scripts/test_dead_code_elim.sh
and/or./example_no_std/check_size.sh
)Validation
GDB output
armv4t output