Allow stop packets with arbitary signal codes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, this seems reasonable to me. Thanks for the PR! Technically, semver lets me make breaking changes before 1.x.y, but if it's not urget, I'd rather lump this in with some other changes I'm making for 0.3. That said, I'll be marking |
daniel5151
pushed a commit
that referenced
this pull request
Aug 26, 2020
daniel5151
pushed a commit
that referenced
this pull request
Aug 26, 2020
|
Also, please ignore the misc. branch thrashing that I just did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
gdbstubonly allows SIGTRAP signals to be used in stop reply packets, however there are other signals that are useful to report (in particular I want to report SIGSEGV).This PR partially issue report with a possible way of allowing this. However, maybe you want to have explicit enum variants for all reasonable stop reasons, and this technically a breaking change, so may need to wait to the next non-patch release.