-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better notification that a notebook was shared for review #14
Comments
Sounds good. Do you have an idea in mind already of where that toaster would appear? Is there another nbextension doing something like this nicely already? |
In jupyter_cms, we pop a notification for the full-page drag-drop upload feature. It appears over the top of the page for a period of time. Here's the implementation: I was thinking something like that. |
We should keep an eye on this, also: jupyterlab/jupyterlab#689 |
Alternative: Open a new browser tab pointing to the Examples tab on the notebook dashboard page and highlight the example shared/updated. This is probably simpler. We could add the highlight information to the browser query string or hash and highlight the appropriate entry when the page loads. |
At present, the submit a notebook button immediately triggers a new windows to open a preview of the shared notebook. It isn't immediately apparent what the button did. Instead, have a toaster come up in the notebook saying "You shared a notebook" or the equivalent, with links to take the user to the preview and/or examples tab on the file dashboard page within it.
The text was updated successfully, but these errors were encountered: