Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better notification that a notebook was shared for review #14

Closed
parente opened this issue Sep 2, 2016 · 4 comments
Closed

Better notification that a notebook was shared for review #14

parente opened this issue Sep 2, 2016 · 4 comments

Comments

@parente
Copy link
Collaborator

parente commented Sep 2, 2016

At present, the submit a notebook button immediately triggers a new windows to open a preview of the shared notebook. It isn't immediately apparent what the button did. Instead, have a toaster come up in the notebook saying "You shared a notebook" or the equivalent, with links to take the user to the preview and/or examples tab on the file dashboard page within it.

@danielballan
Copy link
Owner

Sounds good. Do you have an idea in mind already of where that toaster would appear? Is there another nbextension doing something like this nicely already?

@parente
Copy link
Collaborator Author

parente commented Sep 8, 2016

In jupyter_cms, we pop a notification for the full-page drag-drop upload feature. It appears over the top of the page for a period of time. Here's the implementation:

https://github.com/jupyter-incubator/contentmanagement/blob/master/jupyter_cms/nbextension/common/notify.js

I was thinking something like that.

@danielballan
Copy link
Owner

We should keep an eye on this, also: jupyterlab/jupyterlab#689

@parente
Copy link
Collaborator Author

parente commented Sep 27, 2016

Alternative: Open a new browser tab pointing to the Examples tab on the notebook dashboard page and highlight the example shared/updated.

This is probably simpler. We could add the highlight information to the browser query string or hash and highlight the appropriate entry when the page loads.

@parente parente changed the title Use a toaster to notify a user that a notebook was shared for review Better notification that a notebook was shared for review Sep 27, 2016
parente added a commit to parente/nbexamples that referenced this issue Oct 1, 2016
parente added a commit to parente/nbexamples that referenced this issue Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants