Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix :default_options config name #55

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix :default_options config name #55

merged 1 commit into from
Dec 20, 2018

Conversation

nitinstp23
Copy link
Contributor

There is a typo in Elasticsearch.API.HTTP module where the :default_options config variable is named as default_opts.

@nitinstp23
Copy link
Contributor Author

@danielberkompas Can this be merged?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.0% when pulling 4efa83c on nitinstp23:hotfix/default-options-typo into 40a4d3a on infinitered:master.

@coveralls
Copy link

coveralls commented Dec 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.0% when pulling 4bd9180 on nitinstp23:hotfix/default-options-typo into 40a4d3a on infinitered:master.

@nitinstp23 nitinstp23 force-pushed the hotfix/default-options-typo branch from 4efa83c to 4bd9180 Compare December 20, 2018 13:43
@zberkom zberkom merged commit 55235e3 into danielberkompas:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zberkom zberkom zberkom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitinstp23 @coveralls @zberkom