Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translate pattern to use curly braces #1219

Closed
wants to merge 4 commits into from

Conversation

iqbalabd
Copy link
Contributor

What this Pull Request (PR) does

Updates the pattern for translation to use curly braces so we can insert the target language as a parameter on the command line, i.e

$ cat my-english-text.md | fabric -v=lang_code:ja-jp -p translate

@iqbalabd iqbalabd changed the title Update curly braces Update translate pattern to use curly braces Dec 22, 2024
@mattjoyce
Copy link
Contributor

mattjoyce commented Dec 23, 2024

The language can be specified as a cli options already.
-g, --language= Specify the Language Code for the chat, e.g. -g=en -g=zh

It becomes appended to the system role message.

I'm not saying using it in a pattern is wrong - just sharing.

@iqbalabd
Copy link
Contributor Author

The language can be specified as a cli options already. -g, --language= Specify the Language Code for the chat, e.g. -g=en -g=zh

It becomes appended to the system role message.

I'm not saying using it in a pattern is wrong - just sharing.

Thanks. My understanding of the --language= parameter is that it changes the whole chat language, although it doesn't specify the language to translate to for this particular pattern. Is that correct?

@eugeis
Copy link
Collaborator

eugeis commented Dec 26, 2024

Somehow I can't merge this PR.
There were wrong version files, I deleted them and now no merge possible.
Please create new PR (without version files).

@eugeis eugeis closed this Dec 26, 2024
@iqbalabd iqbalabd deleted the update-curly-braces branch December 26, 2024 23:29
@iqbalabd
Copy link
Contributor Author

For some reason those version files got included in the PR although I did not commit them explicitly. I couldn't figure out why, but I did notice the differences in those files when I compared with the upstream version. Syncing with upstream doesn't seem to work.
So I ended up removing my fork, re-forked it again and this time it worked. Here is the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants