Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only keep two command. One is run and compile directly, And the other is run and compile with args. If the user choose the second command, we will give him two input box. One is about compile args(the default value can be set), the other is about run args(the default value can be set). #16

Closed
andylizf opened this issue Oct 2, 2018 · 10 comments
Closed

Only keep two command. One is run and compile directly, And the other is run and compile with args. If the user choose the second command, we will give him two input box. One is about compile args(the default value can be set), the other is about run args(the default value can be set). #16

andylizf opened this issue Oct 2, 2018 · 10 comments
Labels
enhancement New feature or request

Comments

@andylizf
Copy link
Contributor

andylizf commented Oct 2, 2018

Originally posted by @Anti-Li in #14 (comment)
@andylizf
Copy link
Contributor Author

andylizf commented Oct 2, 2018

Now we have default args, and we should simplified run and compile combination logic.

@danielpinto8zz6
Copy link
Owner

yes, I am still trying to find how to make double input box, since I didn't find it in the api docs

@andylizf
Copy link
Contributor Author

andylizf commented Oct 2, 2018

Show compilation args box, then show the other after successful compilation.

@danielpinto8zz6
Copy link
Owner

I think a box with the 2 input boxes would be more elegand, I know it's possible because I already saw one, but I can't remember where

@andylizf
Copy link
Contributor Author

andylizf commented Oct 2, 2018

impossible.
Just see microsoft/vscode#9936

@danielpinto8zz6
Copy link
Owner

It was 2 years ago, I don't know if it was already added

@andylizf
Copy link
Contributor Author

andylizf commented Oct 3, 2018

Maybe not 😂

@andylizf andylizf changed the title @danielpinto8zz6 Yes, I think it's good way to only keep two command. One is run and compile directly, And the other is run and compile with args. If the user choose the second command, we will give him two input box. One is about compile args(the default value can be set), the other is about run args(the default value can be set). Could you know what I mean? Is it okay? 😃 Only keep two command. One is run and compile directly, And the other is run and compile with args. If the user choose the second command, we will give him two input box. One is about compile args(the default value can be set), the other is about run args(the default value can be set). Oct 3, 2018
@andylizf
Copy link
Contributor Author

andylizf commented Oct 3, 2018 •
edited
Loading

This Feature Request is in Backlog. So I don't think it was already added.

@danielpinto8zz6
Copy link
Owner

So, lets do like you said

@andylizf
Copy link
Contributor Author

andylizf commented Oct 7, 2018

Okay.
And I think it's now unnecessary to keep "only compile" or "only run" commands.

@danielpinto8zz6 danielpinto8zz6 added the enhancement New feature or request label Nov 14, 2018
danielpinto8zz6 added a commit that referenced this issue Dec 1, 2018
@danielpinto8zz6
Merge pull request #43 from Anti-Li/simplify
0863559 
Closes #16. Add "CostumeCompileRun" and shortcut. Simplify the logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielpinto8zz6 @andylizf