- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrome extension for displaying related issues inline #4
Comments
I can work on this. I've built out extensions before. |
Since this is essentially a separate project from the main project @danielroe, can I create a pnpm workspace in this project for the browser extension? For the time being, I'm working off a project on my own account just to get things moving. |
totally up to you! I'm happy with converting this to a workspace or if you prefer keeping it in a separate repo in your account that's fine too! |
I think it makes sense to make it a monorepo. I can set that up as part of my PR. Also, small progress, but I'll work more on this early next week. I've worked on the Refined GitHub browser extension and they run into this issue occasionally as well, but sometimes part of the browser extension breaks because the GitHub UI gets updated. It's just a fact of life for this type of browser extension. That's a long way of me saying I mount the Vue app in the browser extension just after the issue header. Happy to move it elsewhere, but I think it makes more sense at the top because if there are a lot of comments, it would mean scrolling all the way down to see if there were similar issues. I've used a One thing to note is that GitHub.com is a Rails app and they use Turbolinks. This means that if you navigate throughout GitHub and then navigate to an issue page, the browser extension won't load the UI since the For hard-reloads of an issue page, // Listen for Turbo navigation events
document.addEventListener('turbo:load', () => {
console.log('[vitesse-webext] Turbo navigation detected')
initializeApp()
})
// Initial check if we're coming from a full server-side page load
initializeApp() Progress is here atm, https://github.com/nickytonline/unsightdotdev-webext, until I create a monorepo branch. |
this is pretty exciting! I also (locally) have a duplicates endpoint which seems to be very good at actually detecting dupes |
No description provided.
The text was updated successfully, but these errors were encountered: