New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative scales #141

Merged

danielward27 merged 3 commits into main from negative_scales

Mar 1, 2024

Owner

danielward27 commented Mar 1, 2024 •

edited

Loading

Added support for negative scales in Affine, Scale and negative diagonal values in TriangularAffine.

Along with this change, we deprecated positivity_constraint, as e.g. it would be equally valid to constraint the values to be negative.

In Affine and Scale, positivity_constraint is renamed to scale_constraint.
In TriangularAffine, positivity_constraint is renamed to diag_constraint.

danielward27 added 3 commits

March 1, 2024 14:51


          Support negative scales values in affine transformations and similar

647b6b9


          scale shape to attribute so invariant under vmapped constructoer

41e2d6e


          Change error type

38f3a56

danielward27 merged commit 8948273 into main

1 check passed

danielward27 deleted the negative_scales branch

March 1, 2024 15:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet