Skip to content
This repository has been archived by the owner on Sep 17, 2023. It is now read-only.

Catching exceptions in Changes.ObserveContinuous() #176

Merged

Conversation

SamuelWeibel
Copy link
Contributor

Changes.ObserveContinuous() was not properly handling two exceptional cases:

  1. when the response was not successful (e.g. bad parameters, etc.) the returned observable would never complete
  2. when the connection to the server was lost (e.g. when the server restarts), the failure would also not be reported to the observable; this way, the observable would never know that the observation is no longer working.

I didn't write an integration test for this yet, as I didn't try to run integration tests at all. Please feel free to add one (might require some hacking for case number two above) or ask me to write something if needed.

@danielwertheim danielwertheim merged commit f0783e5 into danielwertheim:master Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants