Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

need to update copy of MusyngKite's name.json #48

Closed
kirlen opened this issue Jul 14, 2017 · 3 comments
Closed

need to update copy of MusyngKite's name.json #48

kirlen opened this issue Jul 14, 2017 · 3 comments

Comments

@kirlen
Copy link
Contributor

kirlen commented Jul 14, 2017

instrument names were changed in gleitz' repo on 6/11, causing 404's for multiple instruments, e.g. https://gleitz.github.io/midi-js-soundfonts/MusyngKite/synthbrass_1-mp3.js
(should now be https://gleitz.github.io/midi-js-soundfonts/MusyngKite/synth_brass_1-mp3.js)

See: https://github.com/gleitz/midi-js-soundfonts/commits/gh-pages/MusyngKite/names.json

kirlen added a commit to NYUMusEdLab/fork-soundfont-player that referenced this issue Jul 14, 2017
danigb added a commit that referenced this issue Jul 14, 2017
@danigb
Copy link
Owner

danigb commented Jul 14, 2017

Hi @kirlen,

thanks for reporting 👍 Is your #48 PR a fix of this issue? If so, can we close this issue?

Regards,
Dani

@kirlen
Copy link
Contributor Author

kirlen commented Jul 14, 2017

Hi,
Yes it's a fix -- the one thing i forgot to do was bump the package version -- which I've submitted another PR for. Not sure if version bump triggers availability on NPM, but that's what I'm hoping :)

@danigb
Copy link
Owner

danigb commented Jul 15, 2017

I've published the last version to NPM. Thanks! 👍

@danigb danigb closed this as completed Jul 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants