Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't decrement frame in setStartAt #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xjpro
Copy link

@xjpro xjpro commented Dec 6, 2018

Quite possible this is just a confusion on my part but I figured I'd submit a PR for discussion's sake.

It seems setStartAt expects a value indexed from 1, where all other functions (goToAndPlay, goToAndPause, setEndAt) are indexed from 0. No other functions does the minus 1, which seems odd to me. I would expect either all functions to decrement their frame argument or for none of them to.

I believe most people are comfortable with the idea that "frames" are 0-indexed so I would advocate to simply make setStartAt consistent with the other functions.

@xjpro xjpro changed the title don't minus 1 frame setStartAt Don't decrement frame in setStartAt Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant