This repository has been archived by the owner on Aug 23, 2024. It is now read-only.
Use triangle lists instead of triangle fans #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To whom this may be useful. This change does allow to run this under moltenVK. moltenVK does not support the use of
VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN
so we just convert these primitives toVK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST
.I guess a more optimized way is possible, but it does the job for me at the moment. Ideally the
VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN
path will remain intact andVK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST
is only used when the Vulkan implementation indicates viaVK_KHR_portability_subset
thatVK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN
must not be used.