-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS #134
Conversation
When this new flag is set then only warnings configured and enabled by pragma warnings are reported. It has no effect without setting check flag Encode::ENCODE_WARN_ON_ERR.
SV_NOSTEAL defined by ppport.h to 0 is buggy and is not suitable for sv_setsv_flags().
This patch copies the perl core's functions that translate between UTF-8 and the equivalent code point. It strips off functionality that isn't likely to ever be needed by Encode. These functions were enhanced in the 5.27 development cycle to meet special needs of Encode. Doing this allows Encode to have the same behavior on any perl that it can be used with. It also fixes various potential security issues when Encode is used on early perls. This is because the earlier translation function to/from UTF-8, weren't really aware of the potential security issues that have been fixed over the years. By using the functions now bundled with Encode, these defective early functions are bypassed.
Thank you! |
This change in Encode-2.99 seems to break the following code (extracted and reproduced from Plack-Middleware-Debug code):
with Encode-2.98:
with Encode-2.99:
|
SvPV() macro may return different value as direct access to SV* buffer via SvPVX() for non-forced scalar. For non-forced scalars SvPV() macro should be used. Therefore always use only SvPV() family of macros and avoid use of SvPVX() family (SvCUR, etc...). Fixes: dankogai#134 (comment)
Hi! @miyagawa This change did not break it as it was broken also before. This is classic dangling pointer problem, you just did not hit it. I prepared fix in new pull request #137 Important change is on line 313 as SvPVX(src) may contain incorrect pointer for scalars like objects with overloaded operators or for magic scalars... |
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
Source: meta-openembedded MR: 00000 Type: Integration Disposition: Merged from meta-openembedded ChangeID: 1636d7d Description: * Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Jeremy Puhlman <[email protected]>
SvPV() macro may return different value as direct access to SV* buffer via SvPVX() for non-forced scalar. For non-forced scalars SvPV() macro should be used. Therefore always use only SvPV() family of macros and avoid use of SvPVX() family (SvCUR, etc...). Fixes: dankogai#134 (comment)
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
* Clean-up whitespace * Add ptest dependencies License-Update: Only use license lines from META.json Upstream release notes: 3.01 $ $Date: 2019/03/13 00:26:18 $ ! Encode.xs patched: Warning: Use of uninitialized value in subroutine entry dankogai/p5-encode#139 (comment) ! Encode/encode.h Pulled: Fix compile error and warning dankogai/p5-encode#138 3.00 2019/01/31 ! Encode.pm VERSION bumped to 3.00 to make PAUSE happy 2.100 2019/01/31 04:26:40 ! Encode.xs MANIFEST + t/xml.t Pulled: Do not access SV* buffer if we have not called SvPV_force() dankogai/p5-encode#137 ! MANIFEST remove utf8messages.t which is already deleted from the repository. 2.99 2019/01/21 03:13:35 ! Unicode/Unicode.xs Unicode/Unicode.pm VERSION++'ed as Perl core needed. dankogai/p5-encode#136 ! encengine.c Pulled: protect do_encode from NULL dst dankogai/p5-encode#135 2.98 2018/04/22 09:02:00 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.xs encengine.c t/decode.t t/enc_eucjp.t t/utf8messages.t t/utf8warnings.t - t/utf8messages.t + t/utf32warnings.t Pulled: Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS dankogai/p5-encode#134 2.98 2018/04/22 09:02:00 ! t/truncated_utf8.t Resolved: RT125131: truncated_utf8.t TODO test pass in blead https://rt.cpan.org/Ticket/Display.html?id=125131 ! Encode.xs Pulled: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes() dankogai/p5-encode#133 ! Unicode/Unicode.xs Pulled: Automatically compute length in attr() macro dankogai/p5-encode#132 ! Encode.xs Pulled: Fix compile warnings on 64bit MS VS2017 dankogai/p5-encode#131 2.97 2018/02/21 12:14:33 ! Encode.xs Pulled: New perls that fixes dankogai/p5-encode#129 https://rt.cpan.org/Ticket/Display.html?id=124399 dankogai/p5-encode#130 2.96 2018/02/11 05:35:26 ! Encode.pm encoding.pm Unicode/Unicode.pm VERSION++ to make bleadperl happy <CADED=K4v5WQ3R7+aTu1xV4q2RcZFT=jriZubqfrHe7PZrgRmDA@mail.gmail.com> 2.95 2018/02/08 00:26:15 ! Encode.pm Encode.xs Encode/encode.h Unicode/Unicode.pm Unicode/Unicode.xs encengine.c Pulled: new perls dankogai/p5-encode#128 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
Introduce new Encode check flag Encode::ONLY_PRAGMA_WARNINGS which would tell Encode that it should report only those warnings which are currently enabled by pragma warnings. When Encode::ONLY_PRAGMA_WARNINGS is not set then Encode would report all warnings. The whole flag Encode::ONLY_PRAGMA_WARNINGS would have no effect when flag Encode::ENCODE_WARN_ON_ERR is not set.
UTF-8 and UTF-16 Encode modules are fixed to respect this new Encode::ONLY_PRAGMA_WARNINGS check flag and behave according to its setting.
This change fixes mess in Encode warnings. For more details see Perl RT bug:
https://rt.perl.org/Public/Bug/Display.html?id=131683
Please review changes. CC @khwilliamson