Allow reexpansion of currently expanding macros during argument evaluation #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation. This fixes danmar#31 as reproduced in TEST_CASE(define_define_11) without breaking code from @ydamigos's comment to danmar#225 as reproduced in TEST_CASE(define_define_11a).
datadiode
force-pushed
the
issue_31_revisited_allow_to_reexpand_currently_expanding_macros_during_argument_evaluation
branch
from
1a921fc to
91f42e6
Compare
…sion for empty varargs, to yield gcc-like behavior also in cases where varargs isn't empty (danmar#66, danmar#130)
datadiode
force-pushed
the
issue_31_revisited_allow_to_reexpand_currently_expanding_macros_during_argument_evaluation
branch
from
9d084ad to
f773611
Compare
datadiode
force-pushed
the
issue_31_revisited_allow_to_reexpand_currently_expanding_macros_during_argument_evaluation
branch
from
170ce4c to
de03748
Compare
…pothetical network host
…he relevant TEST_CASE(define_define_17)
…#241) / Fix an integer truncation warning in testrunner
datadiode
force-pushed
the
issue_31_revisited_allow_to_reexpand_currently_expanding_macros_during_argument_evaluation
branch
from
f017409 to
912d924
Compare
danmar
reviewed
Sep 28, 2024
| @@ -888,7 +886,7 @@ void simplecpp::TokenList::readfile(Stream &stream, const std::string &filename, | |||
| } | |||
|
|
|||
| if (prefix.empty()) | |||
| push_back(new Token(s, location)); // push string without newlines | |||
| push_back(new Token(s, location, isspace(stream.peekChar()))); // push string without newlines | |||
There was a problem hiding this comment.
I believe this is not guaranteed to be portable. we include the <cctype> so we should call std::isspace.
|
@datadiode I am very sorry for so slow review!! Excellent work. |
|
I would just like to replace the isspace with std::isspace but I can try to do that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #31 as reproduced in TEST_CASE(define_define_11) without breaking code from @ydamigos's comment to #225 as reproduced in TEST_CASE(define_define_11a). It thereby also fixes #293.
Subsequent commits in this PR address #66, #130, #241, #296.