-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style design: Nav bar with Infinite Scroll and Group Convo by Date #1565
Conversation
Are you at a spot where I can take a look at the new convo/deleted convo issue? |
Its in the infinite scroll implementation. You want me to include in this same PR or make a New for it? |
O
Got it. I would not merge this without that so you can do whichever is easier |
Updated. Including infinite loop. New convos is now being displayed in the convos list, just the title is not updating |
Closed by mistake. Updated with all cleaned code. Sorry |
Wondering if would be better to hide scroll bar |
I tested briefly and it looks like you fixed the issue with the new convo titles 🎉 About the scroll bar, I think it's good to have it but the position could be optimized a little bit, maybe make it more like on the official OpenAI website (the current lack of space between the title-box and the scroll bar makes it look out of place imo) Overall great job, this is going to be a nice improvement over the current system! 🔥 |
Thank you @fuegovic. I will improve the layout with your suggestion |
@walbercardoso I tested the latest changes you made, it's looking good! 💫 |
…design NewChat Component
Amazing work @walbercardoso As @berry-13 mentioned, there could be better formatting for the icon in the New Chat button |
Agree... gonna improve that |
…design NewChat Component
…design NewChat Component
@walbercardoso thanks so much for this contribution. I'm going to sprint this one out as I'd like to address the following items myself. There's a couple of errors in the browser logs:
This second is due to my configuration but some extra steps you didn't know about need to handle it Next, in the network logs. The fetching should not be so frequent page 1 is being invalidated every time. also these requests should be throttled as they can easily be abused right now. these are also fetching again on refocus, which is a legacy thing but I'll removing it with this update Lastly some styling items: Would like to more closely mirror still (LibreChat on left) And the spinner should be part of the convo items like in ChatGPT: |
Closing for #1708 |
@danny-avila It's always a pleasure to contribute. I started programming in react because of Librechat and since then it has been very rewarding to learn a little more from you all. Love this project. |
Thanks man! Greatly appreciate you taking the time to contribute. I just mean to take over to include these changes in the assistants branch on my schedule. It also gives me the impetus to implement this long awaited styling much sooner than I would've without you. |
Summary
Change the conversations list in the SideBar, grouping Convos by: Today, Last 7 days, Last 30 days, and year
Before:
After:
Change Type
Please delete any irrelevant options.
Checklist