Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style design: Nav bar with Infinite Scroll and Group Convo by Date #1565

Closed
wants to merge 7 commits into from

Conversation

walbercardoso
Copy link
Contributor

Summary

Change the conversations list in the SideBar, grouping Convos by: Today, Last 7 days, Last 30 days, and year

Before:

image

After:
image

Change Type

Please delete any irrelevant options.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila
Copy link
Owner

Are you at a spot where I can take a look at the new convo/deleted convo issue?

@walbercardoso
Copy link
Contributor Author

Its in the infinite scroll implementation. You want me to include in this same PR or make a New for it?

@danny-avila
Copy link
Owner

O

Its in the infinite scroll implementation. You want me to include in this same PR or make a New for it?

Got it. I would not merge this without that so you can do whichever is easier

@walbercardoso
Copy link
Contributor Author

Updated. Including infinite loop. New convos is now being displayed in the convos list, just the title is not updating

@walbercardoso walbercardoso reopened this Jan 24, 2024
@walbercardoso
Copy link
Contributor Author

Closed by mistake. Updated with all cleaned code. Sorry

@walbercardoso walbercardoso changed the title Style design: Group Convo by Date Style design: Nav bar with Infinite Scroll and Group Convo by Date Jan 24, 2024
@walbercardoso
Copy link
Contributor Author

Wondering if would be better to hide scroll bar

@fuegovic
Copy link
Collaborator

Wondering if would be better to hide scroll bar

I tested briefly and it looks like you fixed the issue with the new convo titles 🎉

About the scroll bar, I think it's good to have it but the position could be optimized a little bit, maybe make it more like on the official OpenAI website (the current lack of space between the title-box and the scroll bar makes it look out of place imo)

LibreChat
image

OpenAI
image

Overall great job, this is going to be a nice improvement over the current system! 🔥

@walbercardoso
Copy link
Contributor Author

Wondering if would be better to hide scroll bar

I tested briefly and it looks like you fixed the issue with the new convo titles 🎉

About the scroll bar, I think it's good to have it but the position could be optimized a little bit, maybe make it more like on the official OpenAI website (the current lack of space between the title-box and the scroll bar makes it look out of place imo)

LibreChat image

OpenAI image

Overall great job, this is going to be a nice improvement over the current system! 🔥

Thank you @fuegovic. I will improve the layout with your suggestion

@fuegovic
Copy link
Collaborator

@walbercardoso I tested the latest changes you made, it's looking good! 💫

@walbercardoso
Copy link
Contributor Author

I think its done:

image

Icon changes based on Endpoint selected

@walbercardoso
Copy link
Contributor Author

Also, it improved a fade effect of the convos

image

@berry-13
Copy link
Collaborator

I think its done:

image

Icon changes based on Endpoint selected

why is the icon so big?

@danny-avila
Copy link
Owner

Amazing work @walbercardoso

As @berry-13 mentioned, there could be better formatting for the icon in the New Chat button

On official when hovering:
image

@walbercardoso
Copy link
Contributor Author

Amazing work @walbercardoso

As @berry-13 mentioned, there could be better formatting for the icon in the New Chat button

On official when hovering: image

Agree... gonna improve that

@walbercardoso
Copy link
Contributor Author

image

Its done

@danny-avila
Copy link
Owner

@walbercardoso thanks so much for this contribution. I'm going to sprint this one out as I'd like to address the following items myself.

There's a couple of errors in the browser logs:

Warning: Cannot update a component (Nav) while rendering a different component (Landing). To locate the bad setState() call inside Landing, follow the stack trace as described in https://reactjs.org/link/setstate-in-render

Uncaught (in promise) Error: Unknown endpoint: Mistral

This second is due to my configuration but some extra steps you didn't know about need to handle it

Next, in the network logs. The fetching should not be so frequent

LibreChat
image

ChatGPT:
image

page 1 is being invalidated every time. also these requests should be throttled as they can easily be abused right now. these are also fetching again on refocus, which is a legacy thing but I'll removing it with this update

Lastly some styling items:

Would like to more closely mirror still (LibreChat on left)

And the spinner should be part of the convo items like in ChatGPT:

image

@danny-avila
Copy link
Owner

Closing for #1708

@danny-avila danny-avila closed this Feb 2, 2024
@walbercardoso
Copy link
Contributor Author

@danny-avila It's always a pleasure to contribute. I started programming in react because of Librechat and since then it has been very rewarding to learn a little more from you all. Love this project.

@danny-avila
Copy link
Owner

@danny-avila It's always a pleasure to contribute. I started programming in react because of Librechat and since then it has been very rewarding to learn a little more from you all. Love this project.

Thanks man! Greatly appreciate you taking the time to contribute. I just mean to take over to include these changes in the assistants branch on my schedule. It also gives me the impetus to implement this long awaited styling much sooner than I would've without you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants