Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 fix: Address Convo/Preset Switching Issues #2709

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented May 14, 2024

Summary

  • Addressed Mentions not using active index when cycling through mention items
  • Correctly navigate to new conversation when deleting/archiving a new, active convo
  • Ensure openAI/custom/gptPlugins presets only have one label value present (chatGptLabel), despite two different fields (chatGptLabel and modelLabel being interchangeable)
    • This issue would prevent "presets" from correctly taking effect or saving the correct label value when they are available along with "modelSpecs"
  • Handle Error display issue when enforceModelSpecs correctly blocks a request for an existing conversation

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Manual tests, will soon add E2E tests

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@danny-avila danny-avila merged commit 94eeec3 into main May 14, 2024
2 checks passed
@danny-avila danny-avila deleted the preset-fixes branch May 14, 2024 19:19
danny-avila added a commit that referenced this pull request Aug 5, 2024
* fix(schemas): interchangeability between chatGptLabel <> modelLabel

* fix: display error message from enforceModelSpecs when conversation already existed

* fix(Mention): use activeIndex on mention tab/enter

* fix: correctly navigate to new conversation when deleting/archiving a new, active convo
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
* fix(schemas): interchangeability between chatGptLabel <> modelLabel

* fix: display error message from enforceModelSpecs when conversation already existed

* fix(Mention): use activeIndex on mention tab/enter

* fix: correctly navigate to new conversation when deleting/archiving a new, active convo
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
* fix(schemas): interchangeability between chatGptLabel <> modelLabel

* fix: display error message from enforceModelSpecs when conversation already existed

* fix(Mention): use activeIndex on mention tab/enter

* fix: correctly navigate to new conversation when deleting/archiving a new, active convo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant