Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is pip really required at runtime? #155

Closed
edgarrmondragon opened this issue Oct 28, 2024 · 3 comments · Fixed by #156
Closed

Is pip really required at runtime? #155

edgarrmondragon opened this issue Oct 28, 2024 · 3 comments · Fixed by #156

Comments

@edgarrmondragon
Copy link
Contributor

Recent update 8d3ac9a made pip a runtime dependency of this library.

It doesn't seem to be used anywhere and it brings a new dependency into environments where simpleeval is installed.

Can it me removed, or even just moved to an extra or make it a dev dependency?
edgarrmondragon added a commit to edgarrmondragon/simpleeval that referenced this issue Oct 30, 2024
@edgarrmondragon
Remove runtime dependency on pip
2915217 
Closes danthedeckie#155
@edgarrmondragon edgarrmondragon mentioned this issue Oct 30, 2024
Merged
3 tasks
@edgarrmondragon
Copy link
Contributor Author

I opened a PR: #156

@edgarrmondragon edgarrmondragon mentioned this issue Oct 30, 2024
Merged
@danthedeckie
Copy link
Owner

Hey @edgarrmondragon -

Thanks so much, and sorry for the mistake.

I've released 1.0.2 with that requirement removed.

https://pypi.org/project/simpleeval/1.0.2/

@mgorny
Copy link

mgorny commented Oct 31, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove runtime dependency on pip edgarrmondragon/simpleeval
3 participants
@mgorny @danthedeckie @edgarrmondragon