fix date format #1023
Merged
fix date format #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirabilos
added a commit
to mirabilos/dygraphs
that referenced
this pull request
Sep 11, 2022
danvk#1023 Since we added the changes from upstream git master in the last merge commit we’ll also want this. | commit 12822e7 was meant to remove support for the YYYYMMDD date | format (to avoid trying to parse 20033000 as date) but missed one | place and did not update either test data or documentation; this PR | does that (using a regular expression and manual git diff review to | make sure I didn’t catch any unrelated numbers, hoping I got them all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 12822e7 was meant to remove support for the YYYYMMDD date format (to avoid trying to parse
20033000as date) but missed one place and did not update either test data or documentation; this PR does that (using a regular expression and manualgit diffreview to make sure I didn’t catch any unrelated numbers, hoping I got them all)