Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix range selection when chart is located inside fullscreen element #576

Merged
merged 2 commits into from
Apr 21, 2015
Merged

Fix range selection when chart is located inside fullscreen element #576

merged 2 commits into from
Apr 21, 2015

Conversation

mjanda
Copy link
Contributor

@mjanda mjanda commented Apr 5, 2015

Hello,
when you put chart inside element that's fullscreen (using fullscreen api), range selections start at wrong positions (current findPos clearly uses original position, not zoomed).

If I'm not mistaken, original findPos uses some 12 years old code that was created because getBoundingClientRect didn't exist back then. So I'm proposing this simpler version. Or is there some reason to keep the old one?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 90.94% when pulling 9013cfe on mjanda:master into 8bd58e5 on danvk:master.

@danvk
Copy link
Owner

danvk commented Apr 20, 2015

I like it :)

Since this is a slightly frightening change, could you check that the Karma/mocha tests still pass under a few non-PhantomJS browsers, e.g. Firefox, Safari & IE9?

@mjanda
Copy link
Contributor Author

mjanda commented Apr 21, 2015

Firefox (37) and Safari (8 on Yosemite) both pass, IE9 and IE10 fail many tests both before and after change, so hard to tell if this change broke something new.

@danvk
Copy link
Owner

danvk commented Apr 21, 2015

I'm slightly concerned by this question on Stack Overflow, but I'll go ahead and merge. If there are cross-browser issues, we can deal with them during QA for the 2.0.0 release.

Thanks for bringing findPos into the modern age :)

danvk added a commit that referenced this pull request Apr 21, 2015
Fix range selection when chart is located inside fullscreen element
@danvk danvk merged commit 6b875ae into danvk:master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants