Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setAnnotations' boolean parameter optional. #851

Merged
merged 1 commit into from
May 2, 2017
Merged

Conversation

kberg
Copy link
Collaborator

@kberg kberg commented Mar 7, 2017

Please read the guide to making dygraphs changes:
http://dygraphs.com/changes.html

Pull Requests will only be accepted if:

  • You clearly explain what you're adding and why you believe it's an
    improvement. For example: "Fixes issue Custom drawing circles #123".
  • You adhere to the style of the rest of the dygraphs code base.
  • You write an auto_test for the code that you're adding.

Be sure to document any new options you add. Also be aware that PRs which add
options are likely to be rejected. dygraphs already has many options. If you
can fit your feature into one of those or implement it as a plugin, it will be
more likely to get merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.1%) to 85.06% when pulling b4ddb43 on kberg-patch-1 into aaec6de on master.

@danvk danvk merged commit 00eebc9 into master May 2, 2017
@mirabilos mirabilos deleted the kberg-patch-1 branch January 13, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants