Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source-map dependency #232

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Update source-map dependency #232

merged 1 commit into from
Sep 25, 2022

Conversation

duhdugg
Copy link
Contributor

@duhdugg duhdugg commented Sep 25, 2022

Fixes #231

This comment from the svelte project summarizes the issue: sveltejs/svelte#7728 (comment)

Looks like a bug in source-map 0.7.3 where the load-wasm.js file is incorrectly published (fixed in mozilla/source-map#456). See 0.7.3 vs 0.7.4. Because you're using node 18 where a global fetch exists, it thinks that you're running in the browser.

@danvk
Copy link
Owner

danvk commented Sep 25, 2022

Thanks!

@danvk danvk merged commit 0622994 into danvk:master Sep 25, 2022
@danvk
Copy link
Owner

danvk commented Sep 26, 2022

This should be in the 2.5.3 release. Please let me know if it works for you!

@duhdugg
Copy link
Contributor Author

duhdugg commented Sep 26, 2022

Yes, it works. Thank you!

@mohammed-ibra mohammed-ibra mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when running on Node v18 due to native fetch
2 participants
@duhdugg @danvk