Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderSliver mode error when html input is empty #1320

Closed
vanvixi opened this issue Aug 21, 2024 · 2 comments
Closed

RenderSliver mode error when html input is empty #1320

vanvixi opened this issue Aug 21, 2024 · 2 comments
Assignees
@daohoangson
Labels
question Further information is requested

Comments

@vanvixi
Copy link
Contributor

vanvixi commented Aug 21, 2024

Steps to Reproduce

HTML 





  `HtmlWidget` configuration


   HtmlWidget(
      '',
      renderMode: RenderMode.sliverList,
   )






  Tesing environment


Flutter 3.22.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b0850beeb2 (5 weeks ago) • 2024-07-16 21:43:41 -0700
Engine • revision 235db911ba
Tools • Dart 3.4.4 • DevTools 2.34.3





Expected results



Actual results



A RenderSliverPadding expected a child of type RenderSliver but received a child of type RenderErrorBox.

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @vanvixi
vanvixi




          added
  the 

  bug

  Something isn't working
 label


      Aug 21, 2024

    

  



  


  
    
  
  

    
  vanvixi 

      added a commit
        to vanvixi/flutter_widget_from_html
      that referenced
      this issue

    
      Aug 21, 2024
    
    

      


  

    

      


  

      
        @vanvixi
  





      

        
          🐛 Fix issue (daohoangson#1320):
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          215a06b
        
      

    

  

    

      
  - The widget was not being rendered when the html content is empty

    




    

  




    

    

      
    

    


      

          @daohoangson
daohoangson




              self-assigned this


      Aug 22, 2024

    

  



  


  
    
  
  

    
  daohoangson 

      pushed a commit
      that referenced
      this issue

    
      Aug 22, 2024
    
    

      


  

    

      


  

      
        @vanvixi
  





      

        
          Fix RenderSliver mode error when html input is empty (#1320) (#1321)
        


          
            
          
      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          8d5f959
        
      

    

  




    

  









      

  
      



  

  @daohoangson





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Owner


      

  


  

    

  





      


        


  
    

      
          
Thank you for the bug report & also for the PR. v0.15.2 has been released with the fix.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @daohoangson
daohoangson




            added
      

  question

  Further information is requested

    and removed
      

  bug

  Something isn't working

  labels


      Aug 22, 2024

    

  








      

  
      



  

  @vanvixi





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

      

      
            vanvixi
  

      

      

      commented


        Aug 23, 2024


      
    


  





      


        


  
    

      
          
@daohoangson

Good job.

Thank you for created this wonderful lib 🚀🚀🚀

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @vanvixi
vanvixi




            closed this as completed


      Aug 23, 2024

    

  


    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @daohoangson
  
    daohoangson
    

      








      


  


  

    Labels
  



    

      

    question

  Further information is requested








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
    
No branches or pull requests







      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @daohoangson 
        
          @vanvixi