Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16927 pool: refine IV_POOL_HDL IV process #15978

Open
wants to merge 1 commit into
base: liw/special-hdls
Choose a base branch
from
Open

DAOS-16927 pool: refine IV_POOL_HDL IV process #15978

wants to merge 1 commit into from

Conversation

liuxuezhao
Copy link
Contributor

To make the pool_iv_ent_update()->ds_pool_iv_refresh_hdl() be executed before ds_pool_iv_srv_hdl_update() returns.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

DAOS-16927 pool: refine IV_POOL_HDL IV process
dc1dec5 
To make the pool_iv_ent_update()->ds_pool_iv_refresh_hdl() be executed
before ds_pool_iv_srv_hdl_update() returns.

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao requested review from a team as code owners February 26, 2025 02:38
@github-actions GitHub Actions
Copy link

Ticket title is 'Special pool and container handles should be stored persistently in RDBs'
Status is 'In Progress'
Labels: 'request_for_2.6.4'
https://daosio.atlassian.net/browse/DAOS-16927

@liuxuezhao liuxuezhao mentioned this pull request Feb 26, 2025
Open
18 tasks
@liuxuezhao liuxuezhao requested a review from liw February 26, 2025 02:42
liuxuezhao
liuxuezhao commented Feb 26, 2025
View reviewed changes
src/engine/server_iv.c
* IV. One use case is ds_pool_iv_srv_hdl_update() to make the pool_iv_ent_update()->
* ds_pool_iv_refresh_hdl() be executed synchronously.
*/
if (sync && sync->ivs_mode == CRT_IV_SYNC_LAZY && shortcut != CRT_IV_SHORTCUT_TO_ROOT)
return iv_op_async(ns, key, value, sync, shortcut, retry, opc);
Copy link
Contributor Author

@liuxuezhao liuxuezhao Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to totally remove L1178 ~ L1179, now just for safe only bypass it for SHORTCUT TO ROOT case.

@liuxuezhao liuxuezhao requested review from wangdi1 and removed request for a team, liw and wangdi1 February 26, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liuxuezhao