DAOS-9910 pre-commit hooks #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration files for pre-commit tflint tfdocs Added tools/autodoc/terraform_docs.sh which is also used in HPC Toolkit to auto generate documentation in README.md for terraform modules. Added docs/development.md which contains information about installing pre-commit and dependencies and how to install the pre-commit hooks. Added link to docs/development.md on the main readme Signed-off-by: Mark A. Olson <[email protected]>
For MacOS users it's not optional to install findutils and coreutils. The pre-commit hooks in this repo do not work on MacOS unless those packages are installed. Therefore we need to remove the word OPTIONAL. Signed-off-by: Mark A. Olson <[email protected]>
lsitkiew
reviewed
Feb 18, 2022
added 2 commits
February 18, 2022 09:47
Also fixed tflint command in docs/development.md Signed-off-by: Mark A. Olson <[email protected]>
Signed-off-by: Mark A. Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration files for
pre-commit
tflint
tfdocs
Added tools/autodoc/terraform_docs.sh which is also used in HPC Toolkit to auto generate documentation in README.md for terraform modules.
Added docs/development.md which contains information about installing pre-commit and dependencies and how to install the pre-commit hooks.
Added link to docs/development.md on the main readme
Signed-off-by: Mark A. Olson [email protected]