-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOSGCP-75 Example and documentation updates #25
Conversation
1. Renamed example directories for clarity and consistency 2. Updated variable names in examples to be consistent 3. Added terraform.tfvars.*.example files. Values in the files will need to be updated in a following commit 4. Updated main README.md to contain more instructions for getting started 5. Created Cloud Shell tutorial that walks through the one-time setup steps 6. Created Cloud Shell tutorial that walks through the daos_cluster example Signed-off-by: Mark A. Olson <[email protected]>
Set the default image version to 2.0 This will ensure that when images are built, they have the most recent 2.0.x version. The https://packages.daos.io/v2.0/ URL is symlinked to the latest 2.0.x version. Signed-off-by: Mark A. Olson <[email protected]>
Updated command that builds images in the daosgcp_setup.md tutorial to return to the root directory of the repo Signed-off-by: Mark A. Olson <[email protected]>
Signed-off-by: Mark A. Olson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. I think it greatly improves the overall quality of this repo and makes this much more usable.
My only comment is that the tvars examples seem to be inverted...
This takes care of the changes required for DAOSGCP-76 Signed-off-by: Mark A. Olson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Mark. Thanks for helping with the 2 T-Shirt Sizes.
Signed-off-by: Mark A. Olson <[email protected]>
Values in the files will need to be updated in a following commit