Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOSGCP-107 Moved cert scripts from image into terraform #42

Merged
merged 9 commits into from
May 11, 2022
Merged

DAOSGCP-107 Moved cert scripts from image into terraform #42

merged 9 commits into from
May 11, 2022

Conversation

markaolson
Copy link
Contributor

Certificate generation and installation scripts moved
from images to terraform templates and variables.

Signed-off-by: Mark A. Olson [email protected]

@markaolson markaolson requested review from cboneti and lsitkiew May 11, 2022 03:48
Copy link
Contributor

@Kmannth Kmannth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to test but the changes look good to me.

Mark A. Olson added 3 commits May 11, 2022 08:25
Certificate generation and installation scripts moved
from images to terraform templates and variables.

Signed-off-by: Mark A. Olson <[email protected]>
@markaolson markaolson marked this pull request as ready for review May 11, 2022 17:00
Copy link
Contributor

@lsitkiew lsitkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@markaolson markaolson merged commit f08a60a into daos-stack:develop May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants