-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Terraform code to dedicated directory and add main.tf in it #6
Conversation
Signed-off-by: Łukasz Sitkiewicz <[email protected]>
@cboneti any thoughts on this PR? It is very much related to Terraform and i am out of my depth here:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I run it on GCP, after setting up proper project info, all works well.
@lsitkiew There was some discussion today about this approach. The general consensus was there should not be a main.tf for full system setup. If will be best to keep all things modular and composable for future use. In the examples dir it would best to have a few components like: deploy-performance-server Please try and move the full main.tf steps into the examples directory and refactor it into full_cluster_setup. |
Hey folks, I am really sorry for making you wait here. I second what Keith just said, avoiding having a top level main and, instead, having a folder with modules and another with examples. Here are two examples: |
Signed-off-by: Łukasz Sitkiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Łukasz Sitkiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this request on my system and it worked fine. It took me a bit to get terraform.tfvars correctly setup for my setup but docs will help. I can help with the docs in a future submission.
Signed-off-by: Łukasz Sitkiewicz [email protected]