Swap chmod/chown to fix wildcard expansion error #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "sudo chmod +x /var/daos/cert_gen/*.sh" is executed after "sudo chown -R root:root /var/daos/cert_gen" then there is no guarantee that the /var/daos/cert_gen/*.sh part is properly expanded. This is because expansion is performed by the shell invoking sudo and not by the command which is run under sudo. If the invoking shell does not have x permission on /var/daos/cert_gen then chmod will be passed the literal string "/var/daos/cert_gen/*.sh" which it will assume to be a valid path, which it is not. Signed-off-by: Daniel Ahlin <[email protected]>
markaolson
approved these changes
Jul 18, 2022
|
Thank you Daniel! |
markaolson
pushed a commit
that referenced
this pull request
Jul 18, 2022
If "sudo chmod +x /var/daos/cert_gen/*.sh" is executed after "sudo chown -R root:root /var/daos/cert_gen" then there is no guarantee that the /var/daos/cert_gen/*.sh part is properly expanded. This is because expansion is performed by the shell invoking sudo and not by the command which is run under sudo. If the invoking shell does not have x permission on /var/daos/cert_gen then chmod will be passed the literal string "/var/daos/cert_gen/*.sh" which it will assume to be a valid path, which it is not. Signed-off-by: Daniel Ahlin <[email protected]>
mark-olson
pushed a commit
that referenced
this pull request
Dec 8, 2022
If "sudo chmod +x /var/daos/cert_gen/*.sh" is executed after "sudo chown -R root:root /var/daos/cert_gen" then there is no guarantee that the /var/daos/cert_gen/*.sh part is properly expanded. This is because expansion is performed by the shell invoking sudo and not by the command which is run under sudo. If the invoking shell does not have x permission on /var/daos/cert_gen then chmod will be passed the literal string "/var/daos/cert_gen/*.sh" which it will assume to be a valid path, which it is not. Signed-off-by: Daniel Ahlin <[email protected]> Signed-off-by: Mark A. Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
"sudo chmod +x /var/daos/cert_gen/*.sh"
is executed after
"sudo chown -R root:root /var/daos/cert_gen"
then there is no guarantee that the /var/daos/cert_gen/.sh part is properly expanded. This is because expansion is performed by the shell invoking sudo and not by the command which is run under sudo. If the invoking shell does not have x permission on /var/daos/cert_gen then chmod will be passed the literal string "/var/daos/cert_gen/.sh" which it will assume to be a valid path, which it is not.
Signed-off-by: Daniel Ahlin [email protected]