-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-9507 Modifications for DAOS v2.0 #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed image build scripts to install and configure DAOS v2.0. Image family name now includes OS. (Ex. daos-server-centos7) Changed IO500 install script to install IO500 SC21. Updated terraform/examples/io500 to use new os image family names and run IO500 SC21. Refactored env variable names to be more obvious about what they are used for. Signed-off-by: Mark A. Olson <[email protected]>
johannlombardi
previously approved these changes
Jan 10, 2022
Accidentally checked the file in with user specific info. This change corrects that. Signed-off-by: Mark A. Olson <[email protected]>
Set the default disk count for the DAOS server configuration back to 8. Signed-off-by: Mark A. Olson <[email protected]>
cboneti
previously approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Please see two minor questions.
Image names and image family now include the name of the source image. Signed-off-by: Mark A. Olson <[email protected]>
No longer installing IO500 in client images. mpifileutils and IO500 SC21 will now be installed prior to running the IO500 benchmark. The cleanup step that runs before an IO500 run will now set nr_hugepages in daos_server.yml Logging improvements. Signed-off-by: Mark A. Olson <[email protected]>
cboneti
approved these changes
Jan 13, 2022
johannlombardi
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed image build scripts to install and configure
DAOS v2.0. Image scripts no longer install IO500 in the daos-client images.
Image family name now includes OS of source image. (Ex. daos-server-centos-7)
Changed IO500 install script to install IO500 SC21.
Updated terraform/examples/io500 to use new os image family
names and run IO500 SC21.
Refactored env variable names to be more obvious about what
they are used for.
In many of the bash scripts echo statements with a call to a log function which prints colored boxes. This was done to easily distinguish those messages from large amounts of text in the output from the bash scripts.
README.md files updated to reflect changes listed above.
Signed-off-by: Mark A. Olson [email protected]